Skip to content

Remove default available translation for plugins and themes#154

Merged
swissspidy merged 8 commits intowp-cli:mainfrom
dottxado:fix/84
Feb 16, 2026
Merged

Remove default available translation for plugins and themes#154
swissspidy merged 8 commits intowp-cli:mainfrom
dottxado:fix/84

Conversation

@dottxado
Copy link

@dottxado dottxado commented Jun 13, 2024

en_US translations may not be always installed in the case of plugins and themes, so I removed the line of code that assumes the availability of the language for anything different than the core. Now the available translations are the only ones got from wp_get_installed_translations.

I needed to remove some tests because removing the assumption on the language is no more generating a good test case, and this make me think that this solution is not the best one. More in the issue discussion #84

This should fix #84

Related wp-cli/wp-cli#5955

@dottxado dottxado requested a review from a team as a code owner June 13, 2024 08:51
@dottxado dottxado marked this pull request as draft June 13, 2024 09:17
@codecov

This comment was marked as resolved.

@github-actions github-actions bot added command:language-plugin Related to 'language plugin' command command:language-theme Related to 'language theme' command scope:testing Related to testing labels Dec 22, 2025
@swissspidy swissspidy marked this pull request as ready for review February 16, 2026 15:19
Copilot AI review requested due to automatic review settings February 16, 2026 15:19

This comment was marked as resolved.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@swissspidy swissspidy added this to the 2.0.26 milestone Feb 16, 2026
@swissspidy swissspidy merged commit ab6cb0d into wp-cli:main Feb 16, 2026
60 checks passed
@dottxado dottxado deleted the fix/84 branch February 17, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:language-plugin Related to 'language plugin' command command:language-theme Related to 'language theme' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to install translations for en_US

3 participants